fix: return items in _get_render_metadata without validate prereq_met

[jignaciopm]

Description

This PR finds a solution to the problem reported in openedx/frontend-app-learning#1546
The endpoint {{domain}}/api/courseware/sequence/{{sequenceId}} was not returning the units (items) when the section (sequence) had a prerequisite.

Before:
391659904-65c09750-21c9-47d2-b4db-ad37ee1c0ac3.webm

After:
https://github.com/user-attachments/assets/c0864e2d-2ab0-4aa0-bbac-c94f31c35ba5

Supporting information

openedx/frontend-app-learning#1546

Testing instructions

1. Configuring a subsection as a prerequisite
2. Making that subsection the prerequisite of another subsection
3. Go to the prerequisite subsection and navigate to the gated subsection
4. If I try to go to the previous unit right before the gated subsection, the sequence buttons works
5. If from the sidebar I try entering one of the units in the gated subsection, and the previous button works

[openedx-webhooks]

Thanks for the pull request, @jignaciopm!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[felipemontoya]

hello @tecoholic and @viadanna, I asked a review from you guys as you where the last people to modify the line.

It looks like the MFE view is breaking the whole navigation history due to the if prereq_met bit. This was caught by the BTR testing and I'd like to ask if you think this is a reasonable approach?

[tecoholic]

@felipemontoya I just seem to have renamed it from items to blocks. @viadanna, I think you might be better suited to evaluate the changes.

[viadanna]

@felipemontoya The prereq_met bit has been in place since 2018 and was used to make sure the courseware didn't render blocks in gated content when the prerequisites aren't met.

Given the issue is new due to the migration to the MFE, are we sure we want to fix this by changing the behavior of the API? Shouldn't we fix this in the MFE?

[jignaciopm]

Hi @viadanna

I understand. The problem is that I tried different ways from the MFE and I couldn't find a way to solve it because not having the unit of that section, which is a prerequisite, everything gets out of order at the route level because I don't have an identifier to reference in the route.

I understand that it is something that has been around since 2018 but since MFE is something new, perhaps the backend should have been adapted in that place so that it did not break MFE.

For more details on how I arrived at this solution you can see it here openedx/frontend-app-learning#1546 (comment)

@dcoa @bra-i-am How do you see this?

[viadanna]

@jignaciopm Oh, I see, it's not an old bug, but the MFE requires an API behavior change. I'm worried that this would leak information to the client, as it would return the xblocks even when the content is gated. Can it gather just the blocks necessary for the MFE to work instead?