Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: chore(docs/adr): begin recording architectural decisions made on this project with the help of adr-tools #858

Closed
wants to merge 1 commit into from

Conversation

jiridanek
Copy link
Member

https://adr.github.io/

Description

$ brew install adr-tools
$ adr init docs/architecture/decisions

How Has This Been Tested?

This will be tested in production.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…e on this project with the help of adr-tools

```
$ brew install adr-tools
$ adr init docs/architecture/decisions
```
@openshift-ci openshift-ci bot requested review from atheo89 and jstourac January 22, 2025 13:25
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jiridanek. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/s label Jan 22, 2025
@jiridanek
Copy link
Member Author

There's already a place for these, it's in

https://github.com/opendatahub-io/architecture-decision-records/tree/main/architecture-decision-records

and there are subdirectories for individual components there.

@jiridanek jiridanek closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant