Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-17257: chore(tests): externalize the default workbench-starting arguments #856

Merged

Conversation

jiridanek
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-17257

Description

This is the last small improvement/refactoring, I promise.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and caponetto January 22, 2025 11:46
@openshift-ci openshift-ci bot added the size/m label Jan 22, 2025
@jstourac
Copy link
Member

/lgtm

@jiridanek
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member Author

/override ci/prow/images
not applicable

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
not applicable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lgtm label Jan 22, 2025
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/l and removed size/m labels Jan 22, 2025
@jiridanek jiridanek force-pushed the jd_rstudio_render_pdf branch from 0cef10b to 15eeee2 Compare January 22, 2025 12:03
@jiridanek jiridanek added the lgtm label Jan 22, 2025
@openshift-ci openshift-ci bot added size/m and removed size/l labels Jan 22, 2025
@jiridanek
Copy link
Member Author

/override ci/prow/images
not applicable

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
not applicable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override ci/prow/images
not applicable

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
not applicable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit aacd576 into opendatahub-io:main Jan 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants