Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-17257: chore(tests): add allure dependency so that we can have fancy html report #854

Merged

Conversation

jiridanek
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-17257

Description

Allure Report is a popular open source tool for visualizing the results of a test run. It can be added to your testing workflow with little to zero configuration. It produces reports that can be opened anywhere and can be read by anyone, no deep technical knowledge required.

~~ https://allurereport.org/docs/pytest/

image

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and paulovmr January 22, 2025 08:15
@jiridanek jiridanek force-pushed the jd_rstudio_render_pdf branch from e43a4ee to c6aad80 Compare January 22, 2025 08:17
@openshift-ci openshift-ci bot added size/l and removed size/xxl labels Jan 22, 2025
@jiridanek
Copy link
Member Author

can be made even fancier with something like https://github.com/marketplace/actions/generate-allure-report

@jstourac
Copy link
Member

Questions:

  1. This adds just the dependency, but we don't generate a report anywhere yet, correct?
  2. Implementing integration with the GHA seems neat unless there is some easy way to access the report directly eventually.

anyway, whatever

/lgtm

@jiridanek
Copy link
Member Author

This adds just the dependency, but we don't generate a report anywhere yet, correct?

yes, just adding dependency makes this a size/l pr, so I stopped there

Implementing integration with the GHA seems neat unless there is some easy way to access the report directly eventually.

yeah, it's a decent way to attach files to test results; the default github way of attaching zip files to jobs is not very convenient, allure should hopefully be better

/approve

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member Author

/override ci/prow/images
not relevant

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
not relevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 3d7b42d into opendatahub-io:main Jan 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants