Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-8388: rm(intel): fixup to remove one forgotten intel case that's now causing the script to fail #853

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jan 21, 2025

Description

./scripts/test_jupyter_with_papermill.sh: line 345: jupyter_ml_notebook_id: unbound variable

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…at's now causing the script to fail

```
./scripts/test_jupyter_with_papermill.sh: line 345: jupyter_ml_notebook_id: unbound variable
```
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Jan 21, 2025
@jiridanek
Copy link
Member Author

/override ci/prow/images
not relevant for this exercise

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
not relevant for this exercise

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek jiridanek removed the request for review from dibryant January 21, 2025 17:59
@andyatmiami
Copy link
Contributor

/lgtm

we had expected this code (along with others) to be removed - and have confirmed with this fix - no mention of jupyter_ml exists in the test script.

@jiridanek
Copy link
Member Author

/approve
thank you!

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 24884fc into opendatahub-io:main Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/xs tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants