Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-15333: chore(ci): create a Python script that reads Workbench image manifests and outputs snippet suited for inclusion in Docs #796

Closed

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Dec 5, 2024

https://issues.redhat.com/browse/RHOAIENG-15333

Description

Generates the workbench software listings for https://access.redhat.com/articles/rhoai-supported-configs
using the Markdown variant described at https://access.redhat.com/articles/7056942

How Has This Been Tested?

python3 ci/package_versions.py

generates output suitable for https://access.redhat.com/articles/rhoai-supported-configs using the Markdown variant described at https://access.redhat.com/articles/7056942

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

atheo89 and others added 30 commits January 30, 2024 17:01
* Content of R Studio switched to the rhel based image.
Pull all the upstream change and sync
Final fixes on the RStudio Dockerfiles
…r-rstudio

Add BuildConfiguration objects to build RStudio and CUDA R RStudio notebooks oc OCP cluster
…st-updater-7761501425

[Digest Updater Action] Update notebook's imageStreams image tag to digest format
Mount the secret on the buildConfig instead of using ENVs to avoid their exposure on the logs
Fix: Increase resources on R Studio BuildConfigs
Fix naming for RStudio Server on rhel flavor
[CI] Fix for the yaml files that contain multiple definitions.
Co-authored-by: Diamond Bryant <[email protected]>
Signed-off-by: Harshad Reddy Nalla <[email protected]>
Remove the R-package install from workbench
…st-updater-7846262944

[Digest Updater Action] Update notebook's imageStreams image tag to digest format
@openshift-ci openshift-ci bot requested review from atheo89 and caponetto December 5, 2024 09:48
@jiridanek jiridanek self-assigned this Dec 5, 2024
@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 5, 2024
@jiridanek jiridanek force-pushed the jd_doc_snippet_imagestreams branch from ecfead3 to 685e405 Compare January 7, 2025 16:40
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jiridanek. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

import package_versions_selftestdata

"""Generates the workbench software listings for https://access.redhat.com/articles/rhoai-supported-configs
using the Markdown variant described at https://access.redhat.com/articles/7056942"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an open description for https://access.redhat.com/articles/7056942? I don't have access to it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to have RH employee account. You should've gotten this setup when joining the company.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a community repository, IMO we should avoid this kind of URLs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a community repository. ODH is now a Red Hat midstream.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't know whether this is midstream, upstream or whatever. But truth is that we will be using this probably only for the RHOAI product. As such, it isn't required in the opendatahub-io repo but mainly in the rhds one. But I guess I don't care that much. We may want it in this repository e.g. to keep our repos as close as possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I could move this to RHDS, and also I can try to experiment with the markup syntax more, to see if access.redhat.com would accept standard markdown table that also correctly renders on github.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving to rhds, thanks all for comments

ci/package_versions.py Outdated Show resolved Hide resolved
@jiridanek jiridanek force-pushed the jd_doc_snippet_imagestreams branch 2 times, most recently from 5a421ba to a2e7021 Compare January 8, 2025 12:11
"on":
"push":
"pull_request":
"workflow_dispatch":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to run it always or is it enough to run it when the imagestream yaml file is updated only since we use just these to read the data?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very fast, so I vote for running always.

…o the json strings with package version information (opendatahub-io#475)

Previously, we used to have every json string on a single line, which meant we had long hard-to-read lines in our manifests.
Now there is some human-friendly indentation in the files so it should be easier to read.

This is to nave no impact on the data stored, it is a code formatting change only.
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek jiridanek force-pushed the jd_doc_snippet_imagestreams branch from f6590d8 to 35f1199 Compare January 8, 2025 17:43
…h image manifests and outputs snippet suited for inclusion in Docs

Co-authored-by: Guilherme Caponetto <[email protected]>

RHOAIENG-15333: chore(ci): create a Python script that reads Workbench image manifests and outputs snippet suited for inclusion in Docs
@jiridanek jiridanek force-pushed the jd_doc_snippet_imagestreams branch from 35f1199 to e7703be Compare January 8, 2025 17:44
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/intel-notebooks-e2e-tests ecfead3 link true /test intel-notebooks-e2e-tests
ci/prow/rocm-runtimes-ubi9-e2e-tests ecfead3 link true /test rocm-runtimes-ubi9-e2e-tests
ci/prow/runtimes-ubi9-e2e-tests ecfead3 link true /test runtimes-ubi9-e2e-tests
ci/prow/rstudio-notebook-e2e-tests ecfead3 link true /test rstudio-notebook-e2e-tests
ci/prow/codeserver-notebook-e2e-tests ecfead3 link true /test codeserver-notebook-e2e-tests
ci/prow/rocm-notebooks-e2e-tests e7703be link true /test rocm-notebooks-e2e-tests
ci/prow/notebooks-ubi9-e2e-tests e7703be link true /test notebooks-ubi9-e2e-tests
ci/prow/images e7703be link true /test images
ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror e7703be link true /test notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror e7703be link true /test notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror e7703be link true /test notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-11-pr-image-mirror e7703be link true /test notebook-cuda-jupyter-ds-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror e7703be link true /test notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror e7703be link true /test notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek jiridanek closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants