-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-15333: chore(ci): create a Python script that reads Workbench image manifests and outputs snippet suited for inclusion in Docs #796
Conversation
Add rhel9 base image
* Content of R Studio switched to the rhel based image.
Pull all the upstream change and sync
Final fixes on the RStudio Dockerfiles
…es on OCP cluster
…r-rstudio Add BuildConfiguration objects to build RStudio and CUDA R RStudio notebooks oc OCP cluster
Signed-off-by: Harshad Reddy Nalla <[email protected]>
…st-updater-7761501425 [Digest Updater Action] Update notebook's imageStreams image tag to digest format
…eir expose on the logs
Mount the secret on the buildConfig instead of using ENVs to avoid their exposure on the logs
Fix: Increase resources on R Studio BuildConfigs
Fix naming for RStudio Server on rhel flavor
[CI] Fix for the yaml files that contain multiple definitions.
Co-authored-by: Diamond Bryant <[email protected]> Signed-off-by: Harshad Reddy Nalla <[email protected]>
Remove the R-package install from workbench
…st-updater-7846262944 [Digest Updater Action] Update notebook's imageStreams image tag to digest format
…st-updater-12073396903 [Digest Updater Action] Update Notebook Images
Remove Habana imagestream from RHOAI
ecfead3
to
685e405
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
941b2a4
to
bbc062f
Compare
import package_versions_selftestdata | ||
|
||
"""Generates the workbench software listings for https://access.redhat.com/articles/rhoai-supported-configs | ||
using the Markdown variant described at https://access.redhat.com/articles/7056942""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an open description for https://access.redhat.com/articles/7056942? I don't have access to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to have RH employee account. You should've gotten this setup when joining the company.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a community repository, IMO we should avoid this kind of URLs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't know whether this is midstream, upstream or whatever. But truth is that we will be using this probably only for the RHOAI product. As such, it isn't required in the opendatahub-io repo but mainly in the rhds one. But I guess I don't care that much. We may want it in this repository e.g. to keep our repos as close as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I could move this to RHDS, and also I can try to experiment with the markup syntax more, to see if access.redhat.com would accept standard markdown table that also correctly renders on github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moving to rhds, thanks all for comments
5a421ba
to
a2e7021
Compare
"on": | ||
"push": | ||
"pull_request": | ||
"workflow_dispatch": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to run it always or is it enough to run it when the imagestream yaml file is updated only since we use just these to read the data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very fast, so I vote for running always.
…o the json strings with package version information (opendatahub-io#475) Previously, we used to have every json string on a single line, which meant we had long hard-to-read lines in our manifests. Now there is some human-friendly indentation in the files so it should be easier to read. This is to nave no impact on the data stored, it is a code formatting change only.
a2e7021
to
f6590d8
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f6590d8
to
35f1199
Compare
…h image manifests and outputs snippet suited for inclusion in Docs Co-authored-by: Guilherme Caponetto <[email protected]> RHOAIENG-15333: chore(ci): create a Python script that reads Workbench image manifests and outputs snippet suited for inclusion in Docs
35f1199
to
e7703be
Compare
@jiridanek: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/RHOAIENG-15333
Description
Generates the workbench software listings for https://access.redhat.com/articles/rhoai-supported-configs
using the Markdown variant described at https://access.redhat.com/articles/7056942
How Has This Been Tested?
generates output suitable for https://access.redhat.com/articles/rhoai-supported-configs using the Markdown variant described at https://access.redhat.com/articles/7056942
Merge criteria: