-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Intel AI Tools CPU and GPU images. #521
Split Intel AI Tools CPU and GPU images. #521
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @sharvil10. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bb50782
to
d211b84
Compare
OpenShift Release PR: openshift/release#51822 |
d211b84
to
5c7c4d5
Compare
/ok-to-test |
Seems like it failed because the env variables were wrong for the jupyter images. I fixed it in this PR on OpenShift Release CI #51853. |
/retest |
Is it okay to request more resources(CPU and Memory) in the statefulset of jupyter containers to test them? Also, the tests seem to fail arbitrarily locally as well. It works sometimes and sometimes it doesn't with the same error as seen here. |
/retest |
@sharvil10: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@sharvil10 Is it okay to request more resources(CPU and Memory) in the statefulset of jupyter containers to test them? Also, the tests seem to fail arbitrarily locally as well. It works sometimes and sometimes it doesn't with the same error as seen here. In the Opendatahub, user would have the option to pick different resource limits, Was there a reason to close this PR ? |
This PR splits the Intel AI Tools images into CPU and GPU images for Intel TensorFlow and Intel PyTorch.
Description
This PR will split the Intel AI Tools CPU & GPU images into separate images. Th exact changes are described below.
How Has This Been Tested?
This was tested by running make commands to build containers, deploy K8 resources and testing images.
Merge criteria: