Bug fix: Don't forget closing files

openPMD · Aug 9, 2021 · 0d9a9a4 · 0d9a9a4
1 parent 9ff726a
commit 0d9a9a4
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/src/Series.cpp b/src/Series.cpp
@@ -551,13 +551,17 @@ SeriesInterface::flushFileBased( iterations_iterator begin, iterations_iterator
             {
                 using IO = IterationOpened;
             case IO::RemainsClosed:
-                continue;
+                // we might need to proceed further if the close status is
+                // ClosedInFrontend
+                // hence no continue here
+                // otherwise, we might forget to close files physically
+                break;
             case IO::HasBeenOpened:
                 // continue below
+                it->second.flush();
                 break;
             }
 
-            it->second.flush();
 
             if( *it->second.m_closed ==
                 Iteration::CloseStatus::ClosedInFrontend )
@@ -629,13 +633,16 @@ SeriesInterface::flushGorVBased( iterations_iterator begin, iterations_iterator
             {
                 using IO = IterationOpened;
             case IO::RemainsClosed:
-                continue;
+                // we might need to proceed further if the close status is
+                // ClosedInFrontend
+                // hence no continue here
+                break;
             case IO::HasBeenOpened:
                 // continue below
+                it->second.flush();
                 break;
             }
 
-            it->second.flush();
             if( *it->second.m_closed ==
                 Iteration::CloseStatus::ClosedInFrontend )
             {