Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds Tower of Hanoi #33

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

joenorton
Copy link
Contributor

creates game file & test file, modifies games init to add toh

creates game file & test file, modifies games init to add toh
@@ -19,12 +19,12 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks .. and sorry ;-)

@andreaskoepf andreaskoepf merged commit 61293fe into open-thought:main Jan 31, 2025
3 checks passed
@andreaskoepf
Copy link
Contributor

@joenorton In the current version the answer is a list of instructions .. this will not work with the default implementation of score_answer() in the ProceduralDataset base class. Do you maybe want to look into this? e.g. provide a custom score_answer() method in the HanoiDataset class?

@andreaskoepf
Copy link
Contributor

.. beside the optimal solution we should also give non-zero scores for other solutions which used more moves.

@andreaskoepf
Copy link
Contributor

@joenorton I opened an issue for the score_answer() method: #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants