lint

open-thought · Jan 31, 2025 · b49167c · b49167c
1 parent 4ac41bd
commit b49167c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 27 deletions.
diff --git a/reasoning_gym/algorithmic/base_conversion.py b/reasoning_gym/algorithmic/base_conversion.py
@@ -61,33 +61,31 @@ def __getitem__(self, idx: int) -> dict:
 
         # Convert decimal to source base representation
         if source_base == 16:
-            source_repr = format(value, 'x')
+            source_repr = format(value, "x")
         elif source_base == 2:
-            source_repr = format(value, 'b')
+            source_repr = format(value, "b")
         else:
             # Manual conversion for other bases
             n = value
             digits = []
             while n:
                 digits.append(int(n % source_base))
                 n //= source_base
-            source_repr = ''.join(str(d) if d < 10 else chr(ord('a') + d - 10) 
-                                for d in reversed(digits) or [0])
+            source_repr = "".join(str(d) if d < 10 else chr(ord("a") + d - 10) for d in reversed(digits) or [0])
 
         # Convert decimal to target base for answer
         if target_base == 16:
-            target_repr = format(value, 'x')
+            target_repr = format(value, "x")
         elif target_base == 2:
-            target_repr = format(value, 'b')
+            target_repr = format(value, "b")
         else:
             # Manual conversion for other bases
             n = value
             digits = []
             while n:
                 digits.append(int(n % target_base))
                 n //= target_base
-            target_repr = ''.join(str(d) if d < 10 else chr(ord('a') + d - 10) 
-                                for d in reversed(digits) or [0])
+            target_repr = "".join(str(d) if d < 10 else chr(ord("a") + d - 10) for d in reversed(digits) or [0])
 
         source_name = self._format_base_name(source_base)
         target_name = self._format_base_name(target_base)

diff --git a/tests/test_base_conversion.py b/tests/test_base_conversion.py
@@ -65,21 +65,20 @@ def test_base_conversion_dataset_items():
         # Verify conversion correctness
         decimal_value = item["metadata"]["decimal_value"]
         target_base = item["metadata"]["target_base"]
-            
+
         # Use same conversion logic as implementation
         if target_base == 16:
-            expected = format(decimal_value, 'x')
+            expected = format(decimal_value, "x")
         elif target_base == 2:
-            expected = format(decimal_value, 'b')
+            expected = format(decimal_value, "b")
         else:
             # Manual conversion for other bases
             n = decimal_value
             digits = []
             while n:
                 digits.append(int(n % target_base))
                 n //= target_base
-            expected = ''.join(str(d) if d < 10 else chr(ord('a') + d - 10)
-                             for d in reversed(digits) or [0])
+            expected = "".join(str(d) if d < 10 else chr(ord("a") + d - 10) for d in reversed(digits) or [0])
         assert item["answer"] == expected
 
 
@@ -97,14 +96,7 @@ def test_base_conversion_dataset_iteration():
 
 def test_base_conversion_validity():
     """Test that generated numbers are valid for their bases"""
-    config = BaseConversionConfig(
-        min_base=2,
-        max_base=36,
-        min_value=0,
-        max_value=1000,
-        size=100,
-        seed=42
-    )
+    config = BaseConversionConfig(min_base=2, max_base=36, min_value=0, max_value=1000, size=100, seed=42)
     dataset = BaseConversionDataset(config)
 
     def is_valid_for_base(num_str: str, base: int) -> bool:
@@ -113,12 +105,12 @@ def is_valid_for_base(num_str: str, base: int) -> bool:
 
     for i in range(len(dataset)):
         item = dataset[i]
-        assert is_valid_for_base(item["metadata"]["source_repr"], 
-                               item["metadata"]["source_base"]), \
-            f"Invalid source number {item['metadata']['source_repr']} for base {item['metadata']['source_base']}"
-        assert is_valid_for_base(item["metadata"]["target_repr"], 
-                               item["metadata"]["target_base"]), \
-            f"Invalid target number {item['metadata']['target_repr']} for base {item['metadata']['target_base']}"
+        assert is_valid_for_base(
+            item["metadata"]["source_repr"], item["metadata"]["source_base"]
+        ), f"Invalid source number {item['metadata']['source_repr']} for base {item['metadata']['source_base']}"
+        assert is_valid_for_base(
+            item["metadata"]["target_repr"], item["metadata"]["target_base"]
+        ), f"Invalid target number {item['metadata']['target_repr']} for base {item['metadata']['target_base']}"
 
 
 def test_base_conversion_special_bases():