-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k8s.namespace.phase metric and attribute #1668
Conversation
9b13449
to
7e057ce
Compare
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
2eb9c03
to
c50df58
Compare
6fbc61b
to
78efc98
Compare
ddc0634
to
0aabaa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is "phase" a common term in the context of k8s namespaces? (i.e. vs status or state)
I believe so. It's what the API defines and I see it's used in the docs description as well:
|
Signed-off-by: ChrsMark <[email protected]>
Co-authored-by: Jina Jain <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
687cef2
to
21ccf66
Compare
Part of #1032
Changes
This PR adds the
k8s.namespace.phase
as metric along with its respective attributek8s.namespace.phase
.This metric is already in use by the Collector and specifically the
k8scluster
receiver.The introduced attribute is new in order to follow the modeling that is already in use by
hw
metrics andjmx
metrics mentioned at #1032 (comment) (see #1554).Collector implementation: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/9dfa2f7813b11500d001622f3d8c1dd8d9ac58fd/receiver/k8sclusterreceiver/internal/namespace/namespaces.go#L14
K8s API ref: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.30/#namespacestatus-v1-core
Merge requirement checklist
[chore]