Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Page-local dictionary normalization: drop unused words and duplicates (now case-insensitive compare) #6165

Merged
merged 1 commit into from
Feb 1, 2025
Merged

[CI] Page-local dictionary normalization: drop unused words and duplicates (now case-insensitive compare) #6165

merged 1 commit into from
Feb 1, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 1, 2025

  • Updates the page-local dictionary (cSpell:ignore) list, excluding words that don't appear in the page.
  • Drops duplicates from the words list, ignoring case.
  • Ensures that any remaining words that were duplicates are in lower case (so as to match all capitalizations)

@chalin chalin added the CI/infra CI & infrastructure label Feb 1, 2025
@chalin chalin requested a review from a team as a code owner February 1, 2025 03:27
@opentelemetrybot opentelemetrybot requested review from a team February 1, 2025 03:27
@opentelemetrybot opentelemetrybot requested review from evan-bradley and removed request for a team February 1, 2025 03:27
tiffany76
tiffany76 approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin added this pull request to the merge queue Feb 1, 2025
Merged via the queue into open-telemetry:main with commit 748555c Feb 1, 2025
17 checks passed
@chalin chalin deleted the chalin-im-dict-cleanup-2025-01-31 branch February 1, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

@dmathieu dmathieu dmathieu approved these changes

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley was automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
blog CI/infra CI & infrastructure lang:ja lang:pt sig:collector sig:demo sig:dotnet sig:erlang sig:go sig:java sig:javascript sig:operator sig:php sig:python sig:ruby sig:rust
Projects
SIG Comms: Docs Translation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @dmathieu @tiffany76