Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja]Addressed the translation omissions #5983

Merged

Conversation

shukawam
Copy link
Contributor

#5982

I have addressed the translation omissions in the exporter section.
There are still some English parts within the shortcode, but I plan to handle those during the translation of other sections that use the shortcode.

Executed npm run fix:all in my local env and confirmed that there are no issues.

@shukawam shukawam requested a review from a team as a code owner January 19, 2025 04:18
@opentelemetrybot opentelemetrybot requested review from a team January 19, 2025 04:18
@shukawam shukawam changed the title #5982 Addressed the translation omissions #5982 [ja]Addressed the translation omissions Jan 19, 2025
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @shukawam! I added minor requests but other than those, LGTM.

layouts/shortcodes/ja/docs/languages/exporters/intro.md Outdated Show resolved Hide resolved
layouts/shortcodes/ja/docs/languages/exporters/intro.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team January 19, 2025 13:57
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opentelemetrybot opentelemetrybot requested a review from a team January 28, 2025 05:54
@ymotongpoo ymotongpoo force-pushed the chore/localize-exporter-of-concepts branch from a259e38 to 679e3ef Compare February 2, 2025 03:22
@chalin
Copy link
Contributor

chalin commented Feb 2, 2025

LGTM

Hi @ymotongpoo - as mentioned in https://cloud-native.slack.com/archives/C076RUAGP37/p1738265105433829

All: a quick reminder to tag your PRs with the label docs-approval-missing when you have completed your locale-specific review and are awaiting final docs-maintainers approval.

When ja PRs are ready for a final review from @open-telemetry/docs-approvers, add the docs-approval-missing tag tot he PR. Thanks.

@chalin chalin force-pushed the chore/localize-exporter-of-concepts branch from 679e3ef to 8c8b1d3 Compare February 2, 2025 12:30
@chalin chalin added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Feb 2, 2025
@chalin chalin changed the title #5982 [ja]Addressed the translation omissions [ja]Addressed the translation omissions Feb 2, 2025
@chalin chalin added this pull request to the merge queue Feb 2, 2025
Merged via the queue into open-telemetry:main with commit e79f548 Feb 2, 2025
17 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

@shukawam shukawam deleted the chore/localize-exporter-of-concepts branch February 2, 2025 13:51
@ymotongpoo
Copy link
Contributor

@chalin thank you for sharing the process. I could not catch up with the message that mentions the docs-approval-missing tag. I'll make sure to put it for future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer lang:ja
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants