Extending with custom manual instrumentation

[zeitlinger]

Fixes #5713

[svrnm]

thanks

[zeitlinger]

@svrnm can you check?

[svrnm]

One more thing, I am not sure if api is the right name for that, since we do not even mention "api" in the title, description, so either we do that, e.g. "Adding custom instrumentations with the API" or we rename the file to something like "extending-instrumentation.md" as well. wdyt?

[zeitlinger]

One more thing, I am not sure if api is the right name for that, since we do not even mention "api" in the title, description, so either we do that, e.g. "Adding custom instrumentations with the API" or we rename the file to something like "extending-instrumentation.md" as well. wdyt?

it's API to separate it from annotations - which also extend

[zeitlinger]

@svrnm please check again

[zeitlinger]

@svrnm can you check?

[svrnm]

@svrnm can you check?

I did, but I'd like to get some feedback from @open-telemetry/java-approvers or @open-telemetry/java-instrumentation-approvers as well

[zeitlinger]

@jack-berg can you check?

[trask]

I think the sections for the Java agent and Spring Boot starter are great additions.

I only have question about how to structure the addition to the general API page.

[trask]

I'm not sure about the organization of the additions in this file

Maybe could just add two small notes right above here, something like "If you are using the Java agent, see X for information about how to obtain an OpenTelemetry instance" (and similar note for Spring Boot starter)

[jack-berg]

I agree - I think an alert could be good. Something like

{{% alert title="Spring Boot Starter" %}} 
The Spring Boot starter is a special case where [...].
{{% /alert %}}

[zeitlinger]

I think it's useful if to have a hint it the ToC - which is not possible with an info box

[zeitlinger]

@svrnm do you have a recommendation?