-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] Add info about React Native app #5704
[Demo] Add info about React Native app #5704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks good overall, a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general comment, I don't think that the app should be documented as a part of the demo/services
. Even the entry in the index page reads, "React Native mobile application that provides a UI on top of the shopping services."
How does it relate to the Collector?
Maybe we need a new Demo top-level entry?
I actually disagree @chalin.
As well as the other services, the reactive-native-app is instrumented with OTel and sends traces to the Collector. |
I agree with @julianocosta89 here. The |
Marking this as Ready to Review now that the associated PR in the demo repo got merged: open-telemetry/opentelemetry-demo#1781 (comment) Will updated and take a look at the check failures |
I'm not quite sure how to address the failure on the "Build and Check Links" check, it appears to fail on running |
/fix:htmltest-config |
You triggered fix:htmltest-config action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12422284976 |
IMPORTANT: (RE-)RUN
|
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12422305906 |
fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/12422305906. |
I think the issue is fixed, but the CI checks need to be triggered again. Maybe try a rebase? |
@jpmunz @tiffany76 let's ignore the build issues for now, we can fix them once the PR is approved by @open-telemetry/demo-approvers and @open-telemetry/docs-approvers and before we merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 📱📱📱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few small copy edits.
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
hey @tiffany76 thanks for the review! I was away the last 2 weeks and just applied your suggestions now I think everything looks good now though still seeing that failure on the build and check links check: https://github.com/open-telemetry/opentelemetry.io/actions/runs/12638371441/job/35214486467?pr=5704 |
/fix:htmltest-config |
Hi @jpmunz, the PR action is failing for me, even on re-run, and I'm not sure why. We might need @chalin or @svrnm's expertise to fix this. Here's the error message I'm seeing:
|
@jpmunz as a general note, please avoid raising PRs from a fork within an ORG, as they are not editable by maintainers, so we can not use automation or any other ways of helping you to fix this. On the issue, the entry in refcache is missing so please run Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all for your feedback. LGTM if it LGTY, and once all checks are passing.
@jpmunz - please rebase this PR before running the fix commands locally.
@svrnm ah ok I'll keep that in mind about the fork for next time everything looks green after running |
This updates the demo documentation to include the React Native example app that was added here: open-telemetry/opentelemetry-demo#1781
Preview: https://deploy-preview-5704--opentelemetry.netlify.app/docs/demo/services/react-native-app/