Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [es] Create /docs/contributing/new-content.md #5270

Closed

Conversation

TineoC
Copy link
Contributor

@TineoC TineoC commented Sep 30, 2024

Description
This pull request adds the Spanish localization of the /docs/contributing/new-content page on the OpenTelemetry website. The translation includes all sections from the original English document, maintaining the format and structure to ensure consistency with other localized sections.

Changes made:

  • Created the new-content.md file in the docs/es/contributing/ directory.
  • Translated the original content, preserving technical semantics and reference links.
  • Minor adjustments were made to the Markdown content for improved display.

References
This work is related to issue #5205, which tracks the Spanish localization of the contributing documentation folder.

@TineoC TineoC requested a review from a team as a code owner September 30, 2024 06:40
Copy link

linux-foundation-easycla bot commented Sep 30, 2024

CLA Not Signed

@TineoC
Copy link
Contributor Author

TineoC commented Sep 30, 2024

@krol3 @theletterf

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! First review round.

content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested review from a team and svrnm and removed request for a team September 30, 2024 08:04
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
@opentelemetrybot opentelemetrybot requested a review from a team September 30, 2024 11:59
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TineoC Please check the spell checker warnings -- fix or add an exception when required. Thanks!

content/es/docs/contributing/new-content.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested review from a team September 30, 2024 15:30
@TineoC
Copy link
Contributor Author

TineoC commented Oct 1, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11124565569

@opentelemetrybot
Copy link
Collaborator

fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11124545779.

@opentelemetrybot
Copy link
Collaborator

fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11124565569.

@opentelemetrybot opentelemetrybot requested review from a team October 1, 2024 11:53
@theletterf
Copy link
Member

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11124814775

@opentelemetrybot
Copy link
Collaborator

fix:refcache was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@theletterf
Copy link
Member

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11124921520

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@theletterf theletterf added this pull request to the merge queue Oct 1, 2024
@theletterf theletterf removed this pull request from the merge queue due to a manual request Oct 1, 2024
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has changes that it isn't supposed to:

image

As I mentioned earlier, this PR needs to be updated via a rebase (not a merge) to fix the out-of-sync with HEAD issue.

@theletterf
Copy link
Member

@TineoC Could you please rebase from upstream?

@opentelemetrybot opentelemetrybot requested review from a team October 1, 2024 16:14
@theletterf
Copy link
Member

@TineoC It might be simpler to close this PR and open a new one bringing your changes over.

@chalin
Copy link
Contributor

chalin commented Oct 2, 2024

@TineoC - you seem to still be using merge rather than rebase.

image

Note that you first need to fetch the latest upstream main, and then rebase from it. If you aren't sure how to rebase, feel free to ask for help. @theletterf's suggestion of creating a new PR is a good idea too. It's your call.

@theletterf
Copy link
Member

@TineoC Could you try rebasing, as suggested by @chalin ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants