[configuration] Add exception for 'false default' when there is a double negation #4351
+8
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4344.
Changes
Adds exception to naming and default value rule for environment variables.
This is a backwards compatible change since the original statement is phrased as a 'SHOULD'. The
OTEL_SDK_DISABLED
deviates from this new norm (this is not a spec violation but a lack of consistency).The wording tries to be similar to the one in footnote [1] here: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.40.0/specification/protocol/exporter.md
There are several OpenTelemetry artifacts that are either not bound by the specification or have decided, for usability reasons, to not follow this rule in this case. This change would, I argue, bring more consistency and less confusion to end users.
I plan to submit a follow-up PR to change
MeterConfig.disabled
toMeterConfig.enabled
if this PR is accepted.I don't plan to submit a PR to migrate
OTEL_SDK_DISABLED
, but this could be done if there is interest.Thanks to @pellared for guidance on this :)
For non-trivial changes, follow the change proposal process.
enabled
convention #4344Links to the prototypes (when adding or changing features)(not applicable)CHANGELOG.md
file updated for non-trivial changesspec-compliance-matrix.md
updated if necessary