Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KeyValue to avoid copying non-static string slices #2089

Closed
wants to merge 1 commit into from

Update KeyValue

91f0a1d
Select commit
Loading
Failed to load commit list.
Closed

Update KeyValue to avoid copying non-static string slices #2089

Update KeyValue
91f0a1d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 0s

77.9% (+0.0%) compared to 66f29b8

View this Pull Request on Codecov

77.9% (+0.0%) compared to 66f29b8

Details

Codecov Report

Attention: Patch coverage is 64.20455% with 63 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (66f29b8) to head (91f0a1d).

Files with missing lines Patch % Lines
opentelemetry/src/common.rs 68.5% 11 Missing ⚠️
opentelemetry-proto/src/transform/common.rs 11.1% 8 Missing ⚠️
opentelemetry/src/baggage.rs 63.6% 8 Missing ⚠️
opentelemetry-stdout/src/common.rs 0.0% 7 Missing ⚠️
opentelemetry/src/metrics/noop.rs 0.0% 6 Missing ⚠️
opentelemetry/src/trace/noop.rs 0.0% 4 Missing ⚠️
opentelemetry-proto/src/transform/metrics.rs 0.0% 2 Missing ⚠️
opentelemetry/src/global/trace.rs 66.6% 2 Missing ⚠️
opentelemetry/src/metrics/instruments/counter.rs 33.3% 2 Missing ⚠️
opentelemetry/src/metrics/instruments/gauge.rs 33.3% 2 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #2089   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        121     121           
  Lines      20969   20960    -9     
=====================================
+ Hits       16335   16347   +12     
+ Misses      4634    4613   -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov