Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nodejs autoinstrumetation, fixes #2626 #3570

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ElfoLiNk
Copy link

Description:

Update nodejs autoinstrumentation like register.ts from auto-instrumentations-node metapackage

Link to tracking Issue(s):

Testing:

Not tested yet

Documentation:

@ElfoLiNk ElfoLiNk requested a review from a team as a code owner December 22, 2024 10:39
@swiatekm
Copy link
Contributor

@open-telemetry/javascript-approvers could you have a look? 🙏

@ElfoLiNk ElfoLiNk force-pushed the fix/update-nodejs-autoinstrumentation branch from 0b6b81c to cf4ab32 Compare December 30, 2024 17:20
@pavolloffay pavolloffay added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 7, 2025
@ElfoLiNk ElfoLiNk force-pushed the fix/update-nodejs-autoinstrumentation branch from a1389c9 to 04677de Compare January 7, 2025 09:19
@ElfoLiNk
Copy link
Author

ElfoLiNk commented Jan 7, 2025

Thank you @pavolloffay i fixed the build since getResourceDetectorsFromEnv is exported as getResourceDetectors

@pichlermarc
Copy link
Member

Actually, I think since metrics auto-configuration is now implemented, you may not even need the autoconfigure.ts file anymore. It just duplicates what's happening in @opentelemetry/auto-instrumentations-node/register now (the only difference being that the implementation from the upstream package does not throw when a non-existing exporter is selected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js resource detectors can't be disabled with OTEL_NODE_RESOURCE_DETECTORS
4 participants