fix envtest version when latest need golang 1.23 #3360
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -67,6 +67,8 @@ OPERATOR_SDK_VERSION ?= 1.29.0 | |||||
|
|
||||||
| CERTMANAGER_VERSION ?= 1.10.0 | ||||||
|
|
||||||
| ENVTEST_VERSION ?= release-0.18 | ||||||
|
|
||||||
| ifndef ignore-not-found | ||||||
| ignore-not-found = false | ||||||
| endif | ||||||
|
|
@@ -498,7 +500,7 @@ $(CONTROLLER_GEN): $(LOCALBIN) | |||||
| .PHONY: envtest | ||||||
| envtest: $(ENVTEST) ## Download envtest-setup locally if necessary. | ||||||
| $(ENVTEST): $(LOCALBIN) | ||||||
| @test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@$(ENVTEST_VERSION) | ||||||
|
There was a problem hiding this comment. There's some weirdness going on here with the installation in the CI. @huanghuangzym can you try using our install macro instead:
Suggested change
|
||||||
|
|
||||||
| CRDOC = $(shell pwd)/bin/crdoc | ||||||
| .PHONY: crdoc | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use 0.19?
https://github.com/kubernetes-sigs/controller-runtime/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems can not
https://github.com/kubernetes-sigs/controller-runtime/tree/main/tools/setup-envtest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we pin this to https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.5 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release-0.18 maybe 0.18 latest? should we need 0.18 latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're pinning it, I'd prefer a specific tag rather than a branch,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok , i got it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go: downloading sigs.k8s.io/controller-runtime v0.18.5
go: sigs.k8s.io/controller-runtime/tools/[email protected]: module sigs.k8s.io/[email protected] found, but does not contain package sigs.k8s.io/controller-runtime/tools/setup-envtest
it seems can not use specific tag