Move TA config parsing to configmap manifest builder #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
reviewed
Aug 29, 2024
Comment on lines
+125
to
+127
| if len(taScrapeConfigs) > 0 { | ||
| scrapeConfigs = append(scrapeConfigs, taScrapeConfigs...) | ||
| } |
There was a problem hiding this comment.
of note – if someone just creates a targetallocator crd they no longer need to escape scrape configs... this may make it easier for us to use upstream libraries for parsing prometheus in the future.
jaronoff97
reviewed
Aug 29, 2024
jaronoff97
approved these changes
Aug 29, 2024
swiatekm
force-pushed
the
chore/move-config-parsing
branch
from
8e39997 to
069c2a1
Compare
This is in preparation for the Target Allocator CRD. For that CRD, the Collector instance may be specified via a label or ownership relation. Therefore, we need to pull the necessary data from the Collector instance during TA config generation. It's more convenient to do this in all cases, which is what this change does.
swiatekm
force-pushed
the
chore/move-config-parsing
branch
from
069c2a1 to
b95e047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is in preparation for the Target Allocator CRD. For that CRD, the Collector instance may be specified via a label or ownership relation. Therefore, we need to pull the necessary data from the Collector instance during TA config generation. It's more convenient to do this in all cases, which is what this change does.
No current behaviour should change as a result.
Link to tracking Issue(s): #2516
Testing:
Added tests for some new helper functions I introduced.