Prepare Collector reconciliation for TargetAllocator CRD #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor how the target allocator is treated by collector reconciliation.
I've converted
params.TargetAllocatorto a pointer, and now whenever any of the collector manifest builders want to know if a Target Allocator is enabled, they check that pointer instead ofparams.OtelCol.Spec.TargetAllocator.Enabled. The reason for this is that there will be more ways to assign a target allocator to a collector after the TargetAllocator CRD is introduced.Logically, this PR doesn't change anything.
Link to tracking Issue(s): #2422