Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport/v1.x] ci: specify base for release-prep PR #5343

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

The release prep PR for the v1.x branch does not open a PR towards v1.x but defaults to main at the moment. This PR fixes this by specifying a base for the PR.

@pichlermarc pichlermarc added Skip Changelog backport backports to a previous version labels Jan 14, 2025
@pichlermarc pichlermarc requested a review from a team as a code owner January 14, 2025 08:52
@pichlermarc
Copy link
Member Author

see #5342 for an example of this happening (I manually changed the base to v1.x)

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.x@cbc912d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             v1.x    #5343   +/-   ##
=======================================
  Coverage        ?   94.67%           
=======================================
  Files           ?      322           
  Lines           ?     8060           
  Branches        ?     1633           
=======================================
  Hits            ?     7631           
  Misses          ?      429           
  Partials        ?        0           

@pichlermarc pichlermarc merged commit ae2d3a1 into open-telemetry:v1.x Jan 14, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport backports to a previous version Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants