Create new resource from list

open-telemetry · Jan 23, 2025 · 15f54f0 · 15f54f0
1 parent f13ba2c
commit 15f54f0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/opentelemetry-resources/src/Resource.ts b/packages/opentelemetry-resources/src/Resource.ts
@@ -51,8 +51,7 @@ export class Resource implements IResource {
   static FromAttributeList(
     attributes: [string, MaybePromise<AttributeValue | undefined>][]
   ): Resource {
-    // cast required to access private fields
-    const res = Resource.EMPTY as Resource;
+    const res = new Resource({});
     res._rawAttributes = attributes;
     res._asyncAttributesPending =
       attributes.filter(([_, val]) => isPromiseLike(val)).length > 0;

diff --git a/packages/sdk-metrics/test/export/PeriodicExportingMetricReader.test.ts b/packages/sdk-metrics/test/export/PeriodicExportingMetricReader.test.ts
@@ -172,6 +172,7 @@ describe('PeriodicExportingMetricReader', () => {
       merge: sinon.stub(),
       asyncAttributesPending: true, // ensure we try to await async attributes
       waitForAsyncAttributes: waitForAsyncAttributesStub, // resolve when awaited
+      getRawAttributes: () => [],
     },
     scopeMetrics: scopeMetrics,
   };
@@ -383,6 +384,7 @@ describe('PeriodicExportingMetricReader', () => {
           merge: sinon.stub(),
           asyncAttributesPending: true, // ensure we try to await async attributes
           waitForAsyncAttributes: waitForAsyncAttributesStub, // resolve when awaited
+          getRawAttributes: () => [],
         },
         scopeMetrics: scopeMetrics,
       };
@@ -428,6 +430,7 @@ describe('PeriodicExportingMetricReader', () => {
           merge: sinon.stub(),
           asyncAttributesPending: true, // ensure we try to await async attributes
           waitForAsyncAttributes: waitForAsyncAttributesStub, // reject when awaited
+          getRawAttributes: () => [],
         },
         scopeMetrics: [],
       };