Skip to content

Commit

Permalink
Fix latest dep tests (#12774)
Browse files Browse the repository at this point in the history
  • Loading branch information
laurit authored Nov 22, 2024
1 parent bfbfe30 commit 8eef5ca
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ dependencies {
val latestDepTest = findProperty("testLatestDeps") as Boolean
protobuf {
protoc {
val protocVersion = if (latestDepTest) "4.28.2" else "3.19.2"
val protocVersion = if (latestDepTest) "3.25.5" else "3.19.2"
artifact = "com.google.protobuf:protoc:$protocVersion"
}
plugins {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ muzzle {
}
}

val latestDepTest = findProperty("testLatestDeps") as Boolean
dependencies {
bootstrap(project(":instrumentation:internal:internal-application-logger:bootstrap"))

Expand All @@ -30,8 +31,8 @@ dependencies {
}
}

if (findProperty("testLatestDeps") as Boolean) {
testImplementation("ch.qos.logback:logback-classic:+")
if (latestDepTest) {
testImplementation("ch.qos.logback:logback-classic:latest.release")
} else {
testImplementation("ch.qos.logback:logback-classic") {
version {
Expand All @@ -47,3 +48,10 @@ dependencies {

testLibrary("org.springframework.boot:spring-boot-starter:2.5.3")
}

if (latestDepTest) {
// spring 6 requires java 17
otelJava {
minJavaVersionSupported.set(JavaVersion.VERSION_17)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ dependencies {

testLibrary("org.springframework.cloud:spring-cloud-starter-gateway:2.2.0.RELEASE")
testLibrary("org.springframework.boot:spring-boot-starter-test:2.2.0.RELEASE")

// current latest spring cloud is not compatible with spring boot 3.4.0
latestDepTestLibrary("org.springframework.boot:spring-boot-starter-test:3.3.+")
}

tasks.withType<Test>().configureEach {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ public void configure(IgnoredTypesBuilder builder) {
.allowClass("org.springframework.boot.logging.logback.")
.allowClass("org.springframework.boot.web.filter.")
.allowClass("org.springframework.boot.web.servlet.")
.allowClass("org.springframework.boot.web.embedded.netty.GracefulShutdown$$Lambda")
.allowClass("org.springframework.boot.web.embedded.tomcat.GracefulShutdown$$Lambda")
.allowClass(
"org.springframework.boot.actuate.metrics.web.reactive.server.MetricsWebFilter$$Lambda")
.allowClass("org.springframework.boot.autoconfigure.BackgroundPreinitializer$")
Expand Down

0 comments on commit 8eef5ca

Please sign in to comment.