Update documentation around detecting k8s resource attributes #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punya
approved these changes
Dec 20, 2024
aabmass
reviewed
Jan 3, 2025
psx95
force-pushed
the
gcp-resource-detector-doc-fix
branch
from
81f170a to
d6b172d
Compare
trask
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates documentation to clarify the resource attributes being detected for Kubernetes.
Existing Issue(s):
fixes #1609
Documentation/Testing:
The documentation in README is now consistent with the spec and the GCP Resource Detection Sample has been updated to confirm the new documented behavior.
PS: Removed redundant dependency declaration in the build.gradle.kts file.