Enable auto/sdk in otel global #1405
Merged
+272
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
MrAlias
force-pushed
the
otel-global-autosdk
branch
2 times, most recently
from
bc3fd1e to
2cc75b0
Compare
MrAlias
force-pushed
the
otel-global-autosdk
branch
from
0fa0bd8 to
555a184
Compare
This comment was marked as outdated.
This comment was marked as outdated.
MrAlias
force-pushed
the
otel-global-autosdk
branch
from
555a184 to
dab479a
Compare
MrAlias
commented
Dec 17, 2024
internal/pkg/instrumentation/bpf/go.opentelemetry.io/otel/traceglobal/bpf/probe.bpf.c
Show resolved
Hide resolved
MrAlias
force-pushed
the
otel-global-autosdk
branch
5 times, most recently
from
d5356ef to
89c0867
Compare
MrAlias
changed the title
MrAlias
force-pushed
the
otel-global-autosdk
branch
5 times, most recently
from
b25ff44 to
30e7015
Compare
RonFed
reviewed
Dec 20, 2024
internal/pkg/instrumentation/bpf/go.opentelemetry.io/otel/traceglobal/probe.go
Outdated
Show resolved
Hide resolved
internal/pkg/instrumentation/bpf/go.opentelemetry.io/otel/traceglobal/probe.go
Outdated
Show resolved
Hide resolved
MrAlias
commented
Dec 21, 2024
internal/pkg/instrumentation/bpf/go.opentelemetry.io/otel/traceglobal/probe.go
Outdated
Show resolved
Hide resolved
RonFed
reviewed
Dec 21, 2024
internal/pkg/instrumentation/bpf/go.opentelemetry.io/auto/sdk/probe.go
Outdated
Show resolved
Hide resolved
internal/pkg/instrumentation/bpf/go.opentelemetry.io/otel/traceglobal/probe.go
Outdated
Show resolved
Hide resolved
Set the auto/sdk flag in the global API to true when newSpan is called.
Verify the auto/sdk probe is being used.
MrAlias
force-pushed
the
otel-global-autosdk
branch
from
955785e to
4b55aa7
Compare
The span embedded within a context will be from `auto/sdk`. This means that open-telemetry#974 is resolved by this change.
RonFed
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1399
Resolve #1400
Resolve #974
This includes a
probe.Uproberefactor. Instead of passing backlinkswhen the uprobe loads, the uprobe itself now hold these values. When itsClosemethod is called it will, itself, call each of these close methods.This redesign is used so that the
newSpanuprobe can be closed prior to the others (which are closed by theManager).