Fix offsets for golang.org/x/net/http2 (#1208)

* Fix offsets * Add a changelog entry
open-telemetry · Oct 22, 2024 · 78eb1f5 · 78eb1f5
1 parent 741985e
commit 78eb1f5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,11 @@ OpenTelemetry Go Automatic Instrumentation adheres to [Semantic Versioning](http
 - Support `google.golang.org/grpc` `1.69.0-dev`. ([#1203](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/1203))
 - Implement traceID ratio and parent-based samplers. ([#1150](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/1150))
 
+### Fixed
+
+- The `"golang.org/x/net/http2".FrameHeader.StreamID` offset for version `0.8.0` is corrected. ([#1208](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/1208))
+- The `"golang.org/x/net/http2".MetaHeadersFrame.Fields` offset for version `0.8.0` is corrected. ([#1208](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/1208))
+
 ## [v0.15.0-alpha] - 2024-10-01
 
 ### Added

diff --git a/internal/pkg/inject/offset_results.json b/internal/pkg/inject/offset_results.json
@@ -1545,12 +1545,6 @@
               {
                 "field": "StreamID",
                 "offsets": [
-                  {
-                    "offset": null,
-                    "versions": [
-                      "0.8.0"
-                    ]
-                  },
                   {
                     "offset": 8,
                     "versions": [
@@ -1561,6 +1555,7 @@
                       "0.5.0",
                       "0.6.0",
                       "0.7.0",
+                      "0.8.0",
                       "0.9.0",
                       "0.10.0",
                       "0.11.0",
@@ -1595,12 +1590,6 @@
               {
                 "field": "Fields",
                 "offsets": [
-                  {
-                    "offset": null,
-                    "versions": [
-                      "0.8.0"
-                    ]
-                  },
                   {
                     "offset": 8,
                     "versions": [
@@ -1611,6 +1600,7 @@
                       "0.5.0",
                       "0.6.0",
                       "0.7.0",
+                      "0.8.0",
                       "0.9.0",
                       "0.10.0",
                       "0.11.0",