-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otellogr: Fix nil context panic #6527
Open
flc1125
wants to merge
15
commits into
open-telemetry:main
Choose a base branch
from
flc1125:fix-issue-6509
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7860af2
fix #6509
flc1125 eb3b273
fix #6509
flc1125 1a43c6e
fix lint
flc1125 b8f8641
fix lint
flc1125 56945df
test: add nil context test case
flc1125 896c809
test: add nil context test case
flc1125 5afb0e6
Update CHANGELOG.md
flc1125 b3df0b1
Merge branch 'main' into fix-issue-6509
flc1125 16baba2
chore(otellogr): remove custom context support from LogSink
flc1125 1a8a580
Merge remote-tracking branch 'upstream/main' into fix-issue-6509
flc1125 119e5f8
refactor(bridges/otellogr): remove context handling from LogSink
flc1125 599d562
refactor(otellogr): extract context creation in Enabled method for cl…
flc1125 1d47f7a
revert(test): Roll back to the previous unit test
flc1125 00fc8dd
revert(test): Roll back to the previous unit test
flc1125 e74c2c5
Merge branch 'main' into fix-issue-6509
flc1125 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing, but we should be testing the behavior that currently triggers a panic.