otellogr: Fix nil context panic #6527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6527 +/- ##
=====================================
Coverage 68.5% 68.5%
=====================================
Files 200 200
Lines 16781 16782 +1
=====================================
+ Hits 11500 11501 +1
Misses 4935 4935
Partials 346 346
|
dmathieu
changed the title
dmathieu
reviewed
Jan 6, 2025
Co-authored-by: Damien Mathieu <[email protected]>
# Conflicts: # CHANGELOG.md
dmathieu
reviewed
Jan 6, 2025
- Remove `ctx` field and related context handling from `LogSink` struct - Simplify `Enabled` method to use `context.Background()` directly - Remove `WithContext` method and associated tests - Clean up test cases related to context handling
dmathieu
reviewed
Jan 6, 2025
dmathieu
reviewed
Jan 7, 2025
| @@ -176,6 +176,7 @@ func NewLogSink(name string, options ...Option) *LogSink { | |||
| logger: c.provider.Logger(name, opts...), | |||
| levelSeverity: c.levelSeverity, | |||
| opts: opts, | |||
| ctx: context.Background(), | |||
There was a problem hiding this comment.
Last thing, but we should be testing the behavior that currently triggers a panic.
pellared
changed the title
I think this is the proper fix and we probably do not need anything more than this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6509