Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: key for otlp traces protocol app configuration #789

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

tsloughter
Copy link
Member

Fix for #788

This was broken by a find-replace I did when breaking things up across modules. Looking at adding a regression test still.

@tsloughter tsloughter requested a review from a team as a code owner October 21, 2024 10:33
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.20%. Comparing base (eb494e8) to head (3a8cbe1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files          64       64           
  Lines        1941     1941           
=======================================
  Hits         1421     1421           
  Misses        520      520           
Flag Coverage Δ
api 69.90% <ø> (ø)
elixir 17.32% <ø> (ø)
erlang 74.53% <ø> (ø)
exporter 73.17% <ø> (ø)
sdk 77.30% <ø> (ø)
zipkin 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsloughter
Copy link
Member Author

Added regression test. Verified it fails with the old code.

@tsloughter tsloughter merged commit 0a38bd4 into open-telemetry:main Oct 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants