Opentelemetry instrumentation http #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
instrumentation
scope-ci
opentelemetry_cowboy
erlang
utilities
labels
albertored
force-pushed
the
opentelemetry_instrumentation_htpp
branch
from
6ad4824 to
e0885b7
Compare
|
🎉 |
tsloughter
reviewed
Jul 14, 2023
utilities/opentelemetry_instrumentation_http/src/opentelemetry_instrumentation_http.erl
Outdated
Show resolved
Hide resolved
|
I think this is a good first start and just needs to have its changelog reflect what it has in the first commit. |
tsloughter
reviewed
Jul 14, 2023
albertored
force-pushed
the
opentelemetry_instrumentation_htpp
branch
from
e0885b7 to
74707d2
Compare
…_instrumentation_http.erl Co-authored-by: Tristan Sloughter <[email protected]>
This was referenced Jul 15, 2023
tsloughter
approved these changes
Jul 15, 2023
|
@tsloughter how does it work the procedure for publishing this on hex.pm? Once published I can proceed with using it in instrumentation libraries |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion about #183 we thought it would be nice to add a utility library for HTTP instrumentation.
At the moment I included in the lib only the code needed for extracting headers into attributes but it can be extended in the future to add more common functionalities.
Names of the options that each HTTP instrumentation library should expose (for instance to take a list of headers that should be extracted into span attributes) are not included on the library. We can put them here as macros but in that case, we should extend the lib and make it a mixed elixir/erlang one. I think it is an overkill for now but let me know what you think.
I added also the CI stuff (hope it works),