Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: build and push docker builder image #297

Merged
merged 3 commits into from
Jan 7, 2025
Merged

docker: build and push docker builder image #297

merged 3 commits into from
Jan 7, 2025

Conversation

florianl
Copy link
Contributor

@florianl florianl commented Jan 6, 2025 •
edited
Loading

With open-telemetry/community#2283 a Docker repo was requested and provided to host docker images for this project.

This PR helps bringing back reproducible builds. As this project does not yet produce releases the tags latest, that will be overwritten every time, and a timestamp are used instead.

@florianl
Dockerfile: use versioned tag
11f8917 
Replace the moving tag testing with a versioned tag. This helps to
reproduce builds.

Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl marked this pull request as ready for review January 6, 2025 15:20
@florianl florianl requested review from a team as code owners January 6, 2025 15:20
christos68k
christos68k approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@christos68k christos68k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't test fully as the image hasn't yet been uploaded, but I built it locally and that works fine.

@florianl florianl merged commit e297a75 into main Jan 7, 2025
23 checks passed
@florianl florianl deleted the docker branch January 7, 2025 07:09
dmathieu pushed a commit to dmathieu/opentelemetry-ebpf-profiler that referenced this pull request Jan 7, 2025
@florianl @dmathieu
docker: build and push docker builder image (open-telemetry#297)
6f970c9 
Signed-off-by: Florian Lehner <[email protected]>
florianl added a commit that referenced this pull request Jan 13, 2025
@florianl
README: drop make target docker-image as pre requirement
123b195 
Starting with #297 the docker image to build the eBPF profiler is available for everyone.

Signed-off-by: Florian Lehner <[email protected]>
This was referenced Jan 13, 2025
Merged
Closed
Closed
@florianl florianl self-assigned this Jan 17, 2025
teresanovielloatinstana added a commit to instana/opentelemetry-ebpf-profiler that referenced this pull request Jan 17, 2025
@teresanovielloatinstana
Sync from upstream (2025-01-17) (#11)
e2ebf7c 
* Bump golangci-lint to 1.63.4 (open-telemetry#311)
  Author: Tim Rühsen <[email protected]>

* CI: reduce boiler plate of environment (open-telemetry#312)
* Consistent format of the eBPF code (open-telemetry#310)
* Off CPU profiling (open-telemetry#196)
* CI: Check for differences in the eBPF binary blobs (open-telemetry#305)
* README: drop make target docker-image as pre requirement (open-telemetry#304)
  Signed-off-by: Florian Lehner <[email protected]>

* Setup collector receiver (open-telemetry#160)
  Author: Damien Mathieu <[email protected]>
  Co-authored-by: Tim Rühsen <[email protected]>

* Send process name as process.executable.name (/proc/PID/comm) (open-telemetry#298)
  Author: Christos Kalkanis <[email protected]>
  Co-authored-by: Tim Rühsen <[email protected]>

* Remove host metadata collector (open-telemetry#299)
  Author: Damien Mathieu <[email protected]>

* apmint: return error if Attach() fails (open-telemetry#271)
* docker: build and push docker builder image (open-telemetry#297)
  Signed-off-by: Florian Lehner <[email protected]>

* Update golang.org/x/net to v0.33.0 (Fix CVE-2024-45338) (open-telemetry#294)
  Author: Tim Rühsen <[email protected]>

* metrics: update package documentation (open-telemetry#295)
  Signed-off-by: Florian Lehner <[email protected]>

* Fix pdata function table order (open-telemetry#286)
  Author: Tolya Korniltsev <[email protected]>

* Fix cross-compilation (open-telemetry#282) (open-telemetry#290)
  Author: Christos Kalkanis <[email protected]>

* Use clang-17 for building tracers (open-telemetry#270)
  Author: Mathieu Bressolle-Chataigner <[email protected]>
  Co-authored-by: Co-authored-by: Christos Kalkanis
<[email protected]>

* Make the CollAgentAddr config optional in controller (open-telemetry#279)
  Author: Damien Mathieu <[email protected]>
  Co-authored-by: Christos Kalkanis <[email protected]>
  Co-authored-by: Florian Lehner <[email protected]>

* Remove unused type libpf.TraceAndCounts (open-telemetry#283)
  Author: Tim Rühsen <[email protected]>

* Collector Reporter (open-telemetry#208)
  Author: Damien Mathieu <[email protected]>
  Co-authored-by: Tim Rühsen <[email protected]>
  Co-authored-by: Florian Lehner <[email protected]>
  Co-authored-by: Christos Kalkanis <[email protected]>

* proc: handle nvidia kernel modules (open-telemetry#274)
* README: provide new version of devfiler (open-telemetry#275)
  Author: Florian Lehner <[email protected]>

* Extract reporter data generation, and use pdata (open-telemetry#245)
  Author: Damien Mathieu <[email protected]>
  Co-authored-by: Florian Lehner <[email protected]>
  Co-authored-by: Christos Kalkanis <[email protected]>

* apmint: warn user about changes in the APM service (open-telemetry#269)
  Author: Florian Lehner <[email protected]>
  Co-authored-by: Joel Höner <[email protected]>

* coredump: no need for full dump with bundled files (open-telemetry#213)
  Author: Timo Teräs <[email protected]>

* Send executable path with every stack trace (open-telemetry#253)
* Send thread name as ThreadNameKey not ProcessCommandKey (open-telemetry#265)
  Author: Christos Kalkanis <[email protected]>

* proc: Fix parsing Kernel Module lines where refcount is - (open-telemetry#263)
  Author: Frederic Branczyk <[email protected]>

* reporter: extend lifetime for cached elements (open-telemetry#260)
  Author: Florian Lehner <[email protected]>

* Reporter:  allow extending samples with extra attributes (open-telemetry#237)
  Author: Joel Höner <[email protected]>
  Co-authored-by: Tim Rühsen <[email protected]>
teresanovielloatinstana added a commit to instana/opentelemetry-ebpf-profiler that referenced this pull request Jan 21, 2025
@teresanovielloatinstana
Sync from upstream (2025-01-17) (#11)
270db14 
* Bump golangci-lint to 1.63.4 (open-telemetry#311)
  Author: Tim Rühsen <[email protected]>

* CI: reduce boiler plate of environment (open-telemetry#312)
* Consistent format of the eBPF code (open-telemetry#310)
* Off CPU profiling (open-telemetry#196)
* CI: Check for differences in the eBPF binary blobs
  (open-telemetry#305)
* README: drop make target docker-image as pre requirement
  (open-telemetry#304)
  Signed-off-by: Florian Lehner <[email protected]>

* Setup collector receiver (open-telemetry#160)
  Author: Damien Mathieu <[email protected]>
  Co-authored-by: Tim Rühsen <[email protected]>

* Send process name as process.executable.name (/proc/PID/comm)
  (open-telemetry#298)
  Author: Christos Kalkanis <[email protected]>
  Co-authored-by: Tim Rühsen <[email protected]>

* Remove host metadata collector (open-telemetry#299)
  Author: Damien Mathieu <[email protected]>

* apmint: return error if Attach() fails (open-telemetry#271)
* docker: build and push docker builder image (open-telemetry#297)
  Signed-off-by: Florian Lehner <[email protected]>

* Update golang.org/x/net to v0.33.0 (Fix CVE-2024-45338)
  (open-telemetry#294)
  Author: Tim Rühsen <[email protected]>

* metrics: update package documentation (open-telemetry#295)
  Signed-off-by: Florian Lehner <[email protected]>

* Fix pdata function table order (open-telemetry#286)
  Author: Tolya Korniltsev <[email protected]>

* Fix cross-compilation (open-telemetry#282) (open-telemetry#290)
  Author: Christos Kalkanis <[email protected]>

* Use clang-17 for building tracers (open-telemetry#270)
  Author: Mathieu Bressolle-Chataigner <[email protected]>
  Co-authored-by: Co-authored-by: Christos Kalkanis
<[email protected]>

* Make the CollAgentAddr config optional in controller
  (open-telemetry#279)
  Author: Damien Mathieu <[email protected]>
  Co-authored-by: Christos Kalkanis <[email protected]>
  Co-authored-by: Florian Lehner <[email protected]>

* Remove unused type libpf.TraceAndCounts (open-telemetry#283)
  Author: Tim Rühsen <[email protected]>

* Collector Reporter (open-telemetry#208)
  Author: Damien Mathieu <[email protected]>
  Co-authored-by: Tim Rühsen <[email protected]>
  Co-authored-by: Florian Lehner <[email protected]>
  Co-authored-by: Christos Kalkanis <[email protected]>

* proc: handle nvidia kernel modules (open-telemetry#274)
* README: provide new version of devfiler (open-telemetry#275)
  Author: Florian Lehner <[email protected]>

* Extract reporter data generation, and use pdata (open-telemetry#245)
  Author: Damien Mathieu <[email protected]>
  Co-authored-by: Florian Lehner <[email protected]>
  Co-authored-by: Christos Kalkanis <[email protected]>

* apmint: warn user about changes in the APM service
  (open-telemetry#269)
  Author: Florian Lehner <[email protected]>
  Co-authored-by: Joel Höner <[email protected]>

* coredump: no need for full dump with bundled files
  (open-telemetry#213)
  Author: Timo Teräs <[email protected]>

* Send executable path with every stack trace (open-telemetry#253)
* Send thread name as ThreadNameKey not ProcessCommandKey
  (open-telemetry#265)
  Author: Christos Kalkanis <[email protected]>

* proc: Fix parsing Kernel Module lines where refcount is -
  (open-telemetry#263)
  Author: Frederic Branczyk <[email protected]>

* reporter: extend lifetime for cached elements (open-telemetry#260)
  Author: Florian Lehner <[email protected]>

* Reporter:  allow extending samples with extra attributes
  (open-telemetry#237)
  Author: Joel Höner <[email protected]>
  Co-authored-by: Tim Rühsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christos68k christos68k christos68k approved these changes

@rockdaboot rockdaboot rockdaboot approved these changes

Assignees

@florianl florianl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianl @rockdaboot @christos68k