-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interpreter: add support for Python 3.13 #190
Conversation
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
interpreter/python/python.go
Outdated
vms.PyFrameObject.Code = 0 | ||
vms.PyFrameObject.LastI = 56 // _Py_CODEUNIT *prev_instr | ||
vms.PyFrameObject.Back = 8 // struct _PyInterpreterFrame *previous | ||
vms.PyFrameObject.EntryMember = 70 // struct _PyInterpreterFrame owner | ||
vms.PyFrameObject.EntryVal = 3 // enum _frameowner, FRAME_OWNED_BY_CSTACK | ||
vms.PyThreadState.Frame = 72 | ||
vms.PyCFrame.CurrentFrame = 8 | ||
vms.PyASCIIObject.Data = 40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this is mostly same as in 3.12. The difference being just in PyThreadState.Frame
and PyCFrame.CurrentFrame
. But I suppose this is ok for now.
@@ -0,0 +1,77 @@ | |||
""" | |||
gdb python script for dumping Python offsets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for this! This reminds me that we really should make this non-code. I created #191 to track this. Seems Python is the simplest place to start this when the time comes. But definitely for a later PR.
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks! Coredump test might be still useful to add.
Signed-off-by: Florian Lehner <[email protected]>
Python 3.13 was released some days ago. Adjust offsets to support Python 3.13.