Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Add Linux ARM64 to actions CI #5824

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

ysolomchenko
Copy link
Contributor

@ysolomchenko ysolomchenko commented Sep 11, 2024

Partially fixes #1859

Changes

Add otel-linux-arm64 to actions CI

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (6250307) to head (cd7d3ff).
Report is 311 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5824      +/-   ##
==========================================
+ Coverage   83.38%   86.34%   +2.95%     
==========================================
  Files         297      257      -40     
  Lines       12531    11152    -1379     
==========================================
- Hits        10449     9629     -820     
+ Misses       2082     1523     -559     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.19% <ø> (?)
unittests-Project-Stable 86.26% <ø> (?)
unittests-Solution 86.00% <ø> (?)
unittests-UnstableCoreLibraries-Experimental 85.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 215 files with indirect coverage changes

@ysolomchenko ysolomchenko marked this pull request as ready for review September 11, 2024 10:14
@ysolomchenko ysolomchenko requested a review from a team September 11, 2024 10:14
@@ -20,7 +20,7 @@ on:
required: false
type: string
os-list:
default: '[ "windows-latest", "ubuntu-latest" ]'
default: '[ "windows-latest", "ubuntu-latest", "otel-linux-arm64" ]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you get this OS "otel-linux-arm64"? I didn't find it with a simple search.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysolomchenko
Copy link
Contributor Author

@reyang, there is also the possibility of adding Windows ARM to our CI. Should we do it?

@Kielek Kielek changed the title [repo] Add ARM64 to actions CI [repo] Add Linux ARM64 to actions CI Sep 12, 2024
@CodeBlanch CodeBlanch merged commit 2979892 into open-telemetry:main Sep 12, 2024
47 checks passed
@reyang
Copy link
Member

reyang commented Sep 12, 2024

@reyang, there is also the possibility of adding Windows ARM to our CI. Should we do it?

Yeah, that would be nice! (we're seeing more users on mobile, ARM64 servers, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ARM64 Linux/Windows to Actions CI
5 participants