-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Add Linux ARM64 to actions CI #5824
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5824 +/- ##
==========================================
+ Coverage 83.38% 86.34% +2.95%
==========================================
Files 297 257 -40
Lines 12531 11152 -1379
==========================================
- Hits 10449 9629 -820
+ Misses 2082 1523 -559
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -20,7 +20,7 @@ on: | |||
required: false | |||
type: string | |||
os-list: | |||
default: '[ "windows-latest", "ubuntu-latest" ]' | |||
default: '[ "windows-latest", "ubuntu-latest", "otel-linux-arm64" ]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do you get this OS "otel-linux-arm64"? I didn't find it with a simple search.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiang17, these runners are used in https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/. No problems so far.
@reyang, there is also the possibility of adding Windows ARM to our CI. Should we do it? |
Yeah, that would be nice! (we're seeing more users on mobile, ARM64 servers, etc.) |
Partially fixes #1859
Changes
Add otel-linux-arm64 to actions CI
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes