Update native code to upstream tag v2.4.0 #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…native code changes) Changes from DataDog/dd-trace-dotnet@9855be8 adjusted to changes from open-telemetry@909fe3e
Kielek
force-pushed
the
update-native-code-2.4.0
branch
from
7942646 to
3e580be
Compare
Changes from DataDog/dd-trace-dotnet@2d16f74 adjusted by open-telemetry@4d5167f#diff-8bf37bfc95dfd31f530857af76bf993aa717e988084918f54a228d2242ef39d6R171-R173 and dropped enableByRefInstrumentation and enableCallTargetStateByRef (always true)
Kielek
force-pushed
the
update-native-code-2.4.0
branch
from
09c3896 to
698e42d
Compare
lachmatt
approved these changes
Dec 7, 2023
pjanotti
approved these changes
Dec 7, 2023
rajkumar-rangaraj
approved these changes
Dec 7, 2023
nrcventura
approved these changes
Dec 8, 2023
RassK
approved these changes
Dec 9, 2023
zacharycmontoya
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards #3074
Follow up #2280
What
Update native code part based on DataDog/dd-trace-dotnet@v2.3.0...v2.4.0
Continuous profile implementation in SignalFx/Splunk repository relays on changes from this upgrade. It is better to make upgrade first than downgrade donated code.
List of changes:
Skipped DataDog/dd-trace-dotnet@08d734e and DataDog/dd-trace-dotnet@4fdd8a8 as together brings no changes. It will be part for further upgrade to v2.5.0 tag.
Tests
CI
Checklist
[ ]CHANGELOG.mdis updated.[ ] Documentation is updated.[ ] New features are covered by tests.Notes
@zacharycmontoya, please review and check if DataDog is fine with donating these changes.
While reviewing please consider to make commit by commit review, it should be easier.