-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous profiler - test application #3084
Continuous profiler - test application #3084
Conversation
Co-authored-by: Mateusz Łach <[email protected]> Co-authored-by: Robert Pająk <[email protected]>
Can we hold on to this one until we discuss and get consensus from all of the maintainers? |
...t-applications/integrations/dependency-libs/TestApplication.ContinuousProfiler.Fs/ClassFs.fs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...t-applications/integrations/dependency-libs/TestApplication.ContinuousProfiler.Fs/ClassFs.fs
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Pająk <[email protected]>
Sure, it is not first time when we rise this topic and the plan was briefly approved few month ago :) I will wait for @zacharycmontoya, @nrcventura and you before merging this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that having the test apps in place is a good first step.
I think what still needs to be determined is where to place, how to identify, and how to enable the experimental features such as continuous profiling.
8a76780
to
2b88ca4
Compare
Why
Towards #3074
What
Continuous profiler - test application for .NET. It covers:
.NET Framework is not needed, as used solution requires .NET Core 3.1/.NET 5.0+ - which means .NET 6.0 for us.
Test application will be used to generate stack traces to test continuous profiler.
Tests
CI + Added test to check if the application is executed without issues.
Checklist
[ ]CHANGELOG.md
is updated.[ ] Documentation is updated.Notes
Merging this does not affects our plans for 1.2.0 release. It even proofs that application including VB/F#/C++ is still working.