Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shipping] rename shippingservice to shipping #1842

Merged

Conversation

Sozhan308
Copy link
Contributor

@Sozhan308 Sozhan308 commented Dec 15, 2024

Changes

Renames shippingservice to shipping

This is part of getting all services renamed based on the overall #1788 effort for all components in the demo.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@Sozhan308 Sozhan308 requested a review from a team as a code owner December 15, 2024 07:27
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Dec 15, 2024
@puckpuck puckpuck added the docs-update-required Requires documentation update label Dec 19, 2024
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@julianocosta89
Copy link
Member

hey @Sozhan308 could you take care of the merge conflicts?

@Sozhan308
Copy link
Contributor Author

Sozhan308 commented Dec 19, 2024

image

https://www.appdynamics.com/blog/cloud/how-to-observe-opentelemetry-demo-app-in-appdynamics-cloud/ -> this link seems to be broken/not accessible https://github.com/open-telemetry/opentelemetry-demo/blob/main/README.md?plain=1#L112

image

CHANGELOG.md Outdated Show resolved Hide resolved
@julianocosta89 julianocosta89 merged commit fca8fd1 into open-telemetry:main Dec 19, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants