-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ad] rename adService to ad #1832
Conversation
Can you add a Changelog entry to this? |
f458602
to
fd5e241
Compare
fd5e241
to
0edb6b5
Compare
I have updated the changelog |
I updated this PR, to update the environment variable After the changes, I tested it, and Jaeger displayed traces as expected. |
Thank you for updating and testing the changes, @puckpuck. Being new to this project, it took me some time to set it up locally to test the changes. I would also like to learn more about the project and explore opportunities to contribute to other topics. Would it be okay if I reach out to you, @puckpuck, to learn more about the project and its ongoing discussions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some nits but LGTM
a998309
to
6d61d40
Compare
a7142e6
to
2c5397a
Compare
Changes
Renames adservice to ad.
This is part of the ongoing renaming for standarizing the component names
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.