Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configcompression] Mark as stable #9571

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Mark configcompression as Stable

Link to tracking Issue:
Closes #9374

@TylerHelmuth TylerHelmuth marked this pull request as ready for review February 13, 2024 16:18
@TylerHelmuth TylerHelmuth requested review from a team and dmitryax February 13, 2024 16:18
@TylerHelmuth TylerHelmuth changed the title Mark configcompression as stable [configcompression] Mark as stable Feb 13, 2024
@mx-psi
Copy link
Member

mx-psi commented Feb 13, 2024

cc @open-telemetry/collector-approvers

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.90%. Comparing base (94ae776) to head (9b22b4f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9571   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files         348      348           
  Lines       18384    18384           
=======================================
  Hits        16712    16712           
  Misses       1348     1348           
  Partials      324      324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked the code and test coverage.

@bogdandrutu
Copy link
Member

I would personally prefer to stabilize modules in the order of possible dependencies (see #9491) and not mark random modules as stable before we have all the basic modules stable.

@mx-psi
Copy link
Member

mx-psi commented Feb 13, 2024

@bogdandrutu This module does not have any explicit dependency to confmap, consumer or component, and I think the only thing we are assuming from these modules is that we will honor the encoding.TextUnmarshaler interface when unmarshaling configuration.

I don't see us changing this assumption, since this is a Go stdlib interface, but if you think we may change this or you have a different specific concern, I would want to have an issue for it.

@TylerHelmuth TylerHelmuth force-pushed the mark-configcompression-as-stable branch from 7b2fa55 to 0fe0a32 Compare February 20, 2024 18:25
@dmitryax dmitryax merged commit 1a240bb into open-telemetry:main Mar 7, 2024
47 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 7, 2024
@TylerHelmuth TylerHelmuth deleted the mark-configcompression-as-stable branch March 11, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize module configcompression
9 participants