-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[configcompression] Mark as stable #9571
[configcompression] Mark as stable #9571
Conversation
cc @open-telemetry/collector-approvers |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9571 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 348 348
Lines 18384 18384
=======================================
Hits 16712 16712
Misses 1348 1348
Partials 324 324 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked the code and test coverage.
I would personally prefer to stabilize modules in the order of possible dependencies (see #9491) and not mark random modules as stable before we have all the basic modules stable. |
@bogdandrutu This module does not have any explicit dependency to I don't see us changing this assumption, since this is a Go stdlib interface, but if you think we may change this or you have a different specific concern, I would want to have an issue for it. |
7b2fa55
to
0fe0a32
Compare
Description:
Mark
configcompression
as StableLink to tracking Issue:
Closes #9374