-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
confighttp ErrorLog update #12172
Merged
Merged
confighttp ErrorLog update #12172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
reviewed
Jan 23, 2025
mx-psi
approved these changes
Jan 23, 2025
Can you address the linting errors? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12172 +/- ##
==========================================
- Coverage 91.77% 91.76% -0.02%
==========================================
Files 463 463
Lines 24804 24809 +5
==========================================
+ Hits 22764 22766 +2
- Misses 1657 1659 +2
- Partials 383 384 +1 ☔ View full report in Codecov by Sentry. |
@mx-psi Done |
sonalgaud12
changed the title
Add changelog for confighttp ErrorLog update
confighttp ErrorLog update
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Zap as the default error logger in
confighttp.ToServer()
to ensure consistency in logging and to prevent errors from being printed using a different logger. This change configures theErrorLog
field of thehttp.Server
to use a logger backed by Zap, which is initialized with the provided logger inTelemetrySettings
. If the logger creation fails, the function now returnsnil, err
to prevent any undefined behavior from occurring due to an incomplete setup of the logger.Link to tracking issue
Fixes #11820
Documentation
Updated the changelog with information regarding the new default error logger for
confighttp
. Added details to internal documentation to reflect the change and ensure proper usage of the new logging system in server configuration.