[chore] Always initialize cachedItemsCount, it is used in observability sender #12169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
cachedItemsCount
branch
from
7a0a846 to
00881c1
Compare
bogdandrutu
force-pushed
the
cachedItemsCount
branch
3 times, most recently
from
f6e5ce8 to
0774e36
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12169 +/- ##
==========================================
- Coverage 91.82% 91.81% -0.01%
==========================================
Files 463 463
Lines 24776 24767 -9
==========================================
- Hits 22750 22741 -9
Misses 1644 1644
Partials 382 382 ☔ View full report in Codecov by Sentry. |
bogdandrutu
force-pushed
the
cachedItemsCount
branch
from
0774e36 to
acafb06
Compare
…ty sender Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
cachedItemsCount
branch
from
acafb06 to
faf7758
Compare
jmacd
approved these changes
Jan 23, 2025
dmitryax
approved these changes
Jan 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
No need for a changelog since the cache items was added this release. Depends on #12169 --------- Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During #12136 discussion, it was noted that the count may not always be called, but that is not true since we always call it in the observability sender. This PR only simplifies the logic and ensure we always have the right number.