Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] Fix bug where Histograms were marked as not supporting temporaly aggregation #12168

Merged

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jan 23, 2025

@bogdandrutu bogdandrutu requested a review from a team as a code owner January 23, 2025 01:08
@bogdandrutu bogdandrutu force-pushed the fix-bug-histogram-aggregation branch from db64e71 to ccbb869 Compare January 23, 2025 01:08
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (6a546b2) to head (ccbb869).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12168      +/-   ##
==========================================
- Coverage   91.82%   91.80%   -0.02%     
==========================================
  Files         463      463              
  Lines       24774    24774              
==========================================
- Hits        22748    22745       -3     
- Misses       1644     1646       +2     
- Partials      382      383       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised this change doesn't modify any generated code, i guess no components in core are using histograms?

@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 23, 2025
@bogdandrutu
Copy link
Member Author

Yes, very rarely used. I found it because I am trying to see if we can simplify the metrics testing, see #12167. But for telemetry so far we don't test temporality.

Merged via the queue into open-telemetry:main with commit ad36545 Jan 23, 2025
53 checks passed
@bogdandrutu bogdandrutu deleted the fix-bug-histogram-aggregation branch January 23, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants