Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge observability report sender for all signals, remove duplicate code #12165

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

bogdandrutu
Copy link
Member

Depends on #12164

@bogdandrutu bogdandrutu requested review from mx-psi, dmathieu, a team and dmitryax as code owners January 22, 2025 21:14
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 92.77108% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.75%. Comparing base (689d43e) to head (92defee).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/internal/obs_report.go 90.90% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12165      +/-   ##
==========================================
- Coverage   91.76%   91.75%   -0.01%     
==========================================
  Files         463      464       +1     
  Lines       24809    24766      -43     
==========================================
- Hits        22766    22725      -41     
+ Misses       1659     1656       -3     
- Partials      384      385       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu force-pushed the merge-obs-report branch 2 times, most recently from f681d30 to 9783ec9 Compare January 23, 2025 06:39
@bogdandrutu bogdandrutu changed the title Merge observability report sender for all signals, remove duplicate code [chore] Merge observability report sender for all signals, remove duplicate code Jan 23, 2025
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 23, 2025
@jade-guiton-dd
Copy link
Contributor

The only behavior change here is renaming span attributes from (taking spans as example) sent_spans / send_failed_span to a generic items.sent / items.failed, right? (Just confirming, since I'm in the process (#11140) of reviewing the telemetry we have on the OTLP exporters)

@jmacd
Copy link
Contributor

jmacd commented Jan 23, 2025

The only behavior change here is renaming span attributes from (taking spans as example) sent_spans / send_failed_span to a generic items.sent / items.failed, right?

Is that intentional? We can't skip the changelog for a change like that.

@bogdandrutu
Copy link
Member Author

@jmacd added changelog

@bogdandrutu bogdandrutu changed the title [chore] Merge observability report sender for all signals, remove duplicate code Merge observability report sender for all signals, remove duplicate code Jan 23, 2025
@bogdandrutu bogdandrutu enabled auto-merge January 23, 2025 17:25
@bogdandrutu bogdandrutu added Skip Contrib Tests Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jan 23, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 23, 2025
Merged via the queue into open-telemetry:main with commit 765fcef Jan 23, 2025
63 of 67 checks passed
@bogdandrutu bogdandrutu deleted the merge-obs-report branch January 23, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants