Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract componenttest.Telemetry as generic struct for telemetry testing #12151

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners January 22, 2025 00:21
@bogdandrutu bogdandrutu force-pushed the extracttesttel branch 2 times, most recently from a645ca1 to a97ea13 Compare January 22, 2025 05:01
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 16 lines in your changes missing coverage. Please review.

Project coverage is 91.81%. Comparing base (4963da7) to head (6d65a9d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
component/componenttest/obsreporttest.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12151      +/-   ##
==========================================
+ Coverage   91.78%   91.81%   +0.03%     
==========================================
  Files         462      463       +1     
  Lines       24893    24741     -152     
==========================================
- Hits        22847    22715     -132     
+ Misses       1664     1644      -20     
  Partials      382      382              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 22, 2025
@bogdandrutu bogdandrutu removed this pull request from the merge queue due to a manual request Jan 22, 2025
@bogdandrutu bogdandrutu enabled auto-merge January 22, 2025 18:42
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 22, 2025
Merged via the queue into open-telemetry:main with commit c6a0986 Jan 22, 2025
53 of 54 checks passed
@bogdandrutu bogdandrutu deleted the extracttesttel branch January 22, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants