Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][service] Drop component metrics depending on level #12143

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 21, 2025

Description

Drops metrics that depend on the metrics level:

This attemps to unblock #11601 by hardcoding the metrics here since there is a small number of them. Once we do #11754 we can move this back to the individual components

Link to tracking issue

Updates #11061

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.74%. Comparing base (f9341b2) to head (1beb31a).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12143      +/-   ##
==========================================
+ Coverage   91.72%   91.74%   +0.02%     
==========================================
  Files         463      463              
  Lines       24821    24890      +69     
==========================================
+ Hits        22767    22836      +69     
  Misses       1672     1672              
  Partials      382      382              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi force-pushed the mx-psi/level-detailed-batch-hardcode branch 2 times, most recently from a84b816 to aa5aee2 Compare January 21, 2025 11:41
@mx-psi mx-psi changed the title [chore][service] Drop detailed metrics depending on level [chore][service] Drop component metrics depending on level Jan 21, 2025
@mx-psi mx-psi marked this pull request as ready for review January 21, 2025 11:56
@mx-psi mx-psi requested a review from a team as a code owner January 21, 2025 11:56
@mx-psi mx-psi requested a review from songy23 January 21, 2025 11:56
@mx-psi mx-psi marked this pull request as draft January 21, 2025 11:57
@mx-psi

This comment was marked as resolved.

For the following components:
- processor/batch
- contrib's internal/otelarrow/netstats
- otel-arrow library
@mx-psi mx-psi force-pushed the mx-psi/level-detailed-batch-hardcode branch from 4b7546b to 21725d7 Compare January 21, 2025 12:30
@mx-psi mx-psi marked this pull request as ready for review January 21, 2025 12:31
@mx-psi mx-psi requested a review from jmacd January 21, 2025 12:31
github-merge-queue bot pushed a commit that referenced this pull request Jan 21, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Removes `telemetry::level`, which is unused. If this was intended to
serve as the 'minimum level' for a component, I can handle that on
#12143.

This is a breaking change, but since the field was effectively dead I
think that's fine.

#### Link to tracking issue

Updates #11061
@mx-psi mx-psi requested a review from codeboten January 21, 2025 16:48
@mx-psi mx-psi added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@mx-psi mx-psi added this pull request to the merge queue Jan 22, 2025
Merged via the queue into open-telemetry:main with commit 70f9fe9 Jan 22, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants