-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][service] Drop component metrics depending on level #12143
Merged
mx-psi
merged 4 commits into
open-telemetry:main
from
mx-psi:mx-psi/level-detailed-batch-hardcode
Jan 22, 2025
Merged
[chore][service] Drop component metrics depending on level #12143
mx-psi
merged 4 commits into
open-telemetry:main
from
mx-psi:mx-psi/level-detailed-batch-hardcode
Jan 22, 2025
+155
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12143 +/- ##
==========================================
+ Coverage 91.72% 91.74% +0.02%
==========================================
Files 463 463
Lines 24821 24890 +69
==========================================
+ Hits 22767 22836 +69
Misses 1672 1672
Partials 382 382 ☔ View full report in Codecov by Sentry. |
mx-psi
force-pushed
the
mx-psi/level-detailed-batch-hardcode
branch
2 times, most recently
from
January 21, 2025 11:41
a84b816
to
aa5aee2
Compare
mx-psi
changed the title
[chore][service] Drop detailed metrics depending on level
[chore][service] Drop component metrics depending on level
Jan 21, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jan 21, 2025
For the following components: - processor/batch - contrib's internal/otelarrow/netstats - otel-arrow library
mx-psi
force-pushed
the
mx-psi/level-detailed-batch-hardcode
branch
from
January 21, 2025 12:30
4b7546b
to
21725d7
Compare
songy23
reviewed
Jan 21, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Removes `telemetry::level`, which is unused. If this was intended to serve as the 'minimum level' for a component, I can handle that on #12143. This is a breaking change, but since the field was effectively dead I think that's fine. #### Link to tracking issue Updates #11061
songy23
approved these changes
Jan 21, 2025
bogdandrutu
approved these changes
Jan 21, 2025
djaglowski
approved these changes
Jan 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drops metrics that depend on the metrics level:
MetricsLevel
otel-arrow#280 for limitation).LevelNone
drops all metrics.This attemps to unblock #11601 by hardcoding the metrics here since there is a small number of them. Once we do #11754 we can move this back to the individual components
Link to tracking issue
Updates #11061