[component] Allow calling component.ValidateConfig at the top level
#12102
+60
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12102 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 461 461
Lines 24678 24678
=======================================
Hits 22607 22607
Misses 1689 1689
Partials 382 382 ☔ View full report in Codecov by Sentry. |
evan-bradley
force-pushed
the
toplevel-component-validateconfig
branch
from
7c704fa to
c53dbe7
Compare
|
I'm skipping the contrib tests for now, I'll fix any errors with an |
mx-psi
approved these changes
Jan 20, 2025
jade-guiton-dd
approved these changes
Jan 21, 2025
TylerHelmuth
approved these changes
Jan 21, 2025
TylerHelmuth
added
the
ready-to-merge
Merged
via the queue into
open-telemetry:main
with commit Jan 23, 2025
24f88da
67 of 68 checks passed
sincejune
added a commit
to sincejune/opentelemetry-collector
that referenced
this pull request
Jan 24, 2025
…op level (open-telemetry#12102)" This reverts commit 24f88da.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
component.ValidateConfigto recurse through the entire config object by checking forConfigValidatorimplementations of structs that are under interfaces. Right nowValidateConfigstops at things likecomponent.Configwhich themselves can't implementcomponent.ValidateConfigbecausecallValidateIfPossiblecan only see the interface and not the concrete type before this change.Link to tracking issue
Replaces #12058.
Works toward #11524.