Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] exporter batcher - byte size based batching #12017

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sfc-gh-sili
Copy link
Contributor

@sfc-gh-sili sfc-gh-sili commented Jan 5, 2025

Description

  • Change to pdata. This PR adds the interface Size() to pdata.
    • See pdata/internal/cmd/pdatagen/internal/templates/message.go.tmpl
  • Changes to exporter.request:
    • See exporter/exporterhelper/logs_batch.go shows the logic to split based on byte size.

Link to tracking issue

Fixes #

Testing

Documentation

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 5.88235% with 192 lines in your changes missing coverage. Please review.

Project coverage is 90.98%. Comparing base (306c939) to head (43e811c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/logs_batch.go 3.75% 77 Missing ⚠️
exporter/exporterbatcher/config.go 0.00% 8 Missing and 4 partials ⚠️
exporter/internal/queue/default_batcher.go 75.00% 2 Missing and 1 partial ⚠️
exporter/exporterhelper/internal/request.go 0.00% 2 Missing ⚠️
exporter/exporterhelper/logs.go 0.00% 2 Missing ⚠️
exporter/exporterhelper/metrics.go 0.00% 2 Missing ⚠️
exporter/exporterhelper/traces.go 0.00% 2 Missing ⚠️
...xporter/exporterhelper/xexporterhelper/profiles.go 0.00% 2 Missing ⚠️
pdata/pcommon/generated_instrumentationscope.go 0.00% 2 Missing ⚠️
pdata/pcommon/generated_resource.go 0.00% 2 Missing ⚠️
... and 43 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12017      +/-   ##
==========================================
- Coverage   91.70%   90.98%   -0.73%     
==========================================
  Files         455      455              
  Lines       24053    24253     +200     
==========================================
+ Hits        22058    22066       +8     
- Misses       1625     1812     +187     
- Partials      370      375       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant