-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature command #12014
base: main
Are you sure you want to change the base?
Feature command #12014
Conversation
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
…elemetry-collector into feature-command
Signed-off-by: danish9039 <[email protected]>
|
||
func newFeaturesCommand() *cobra.Command { | ||
return &cobra.Command{ | ||
Use: "features [feature-id]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@open-telemetry/collector-approvers do you prefer features? gates? featuregates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
features
sounds better to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs a changelog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12014 +/- ##
==========================================
- Coverage 91.70% 91.60% -0.11%
==========================================
Files 455 455
Lines 24053 24087 +34
==========================================
+ Hits 22058 22064 +6
- Misses 1625 1652 +27
- Partials 370 371 +1 ☔ View full report in Codecov by Sentry. |
Description
Link to tracking issue
Testing
make
make test
Documentation