Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][wokflow]: fix codeowner check #36729

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[chore][wokflow]: fix codeowner check #36729

merged 1 commit into from
Dec 9, 2024

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Dec 9, 2024 •
edited
Loading

No description provided.

@VihasMakwana VihasMakwana requested a review from a team as a code owner December 9, 2024 17:10
@VihasMakwana VihasMakwana requested a review from songy23 December 9, 2024 17:10
@VihasMakwana VihasMakwana mentioned this pull request Dec 9, 2024
Closed
songy23
songy23 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still failing but as I recall we need to merge this PR to mainline to see the effect

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Dec 9, 2024
@VihasMakwana
Copy link
Contributor Author

It's still failing but as I recall we need to merge this PR to mainline to see the effect

Yup.

@codeboten codeboten merged commit 6552f4f into open-telemetry:main Dec 9, 2024
169 of 170 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 9, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@VihasMakwana @sbylica-splunk
[chore][wokflow]: fix codeowner check (open-telemetry#36729)
e46d854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@mwear mwear mwear approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Milestone
v0.116.0
Development

Successfully merging this pull request may close these issues.
5 participants
@VihasMakwana @codeboten @mwear @songy23 @bogdandrutu